From e5d2a95d685b82d488e682ae7c255d38f189049e Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Mon, 10 Oct 2016 07:52:00 +0200 Subject: [PATCH] src: remove out-of-date TODO comment This commit attempts to fix one of the items in https://github.com/nodejs/node/issues/4641, which was to remove a TODO the UDPWrap::OnSend function and share the code in that method with StreamWrap::AfterWrite. While looking into this addaleax pointed out that the implementations for these two functions have diverged since the original comment was added: $ git log --pretty=short -u -L 357,357:src/udp_wrap.cc $ git show cbd4033619cc45abdf878285c412bac9c3f36e4e:src/udp_wrap.cc | grep -1 -A26 'UDPWrap::OnSend' git show cbd4033619cc45abdf878285c412bac9c3f36e4e:src/stream_wrap.cc | grep -A27 'void StreamWrap::AfterWrite' Removing the TODO comment seems appropriate in this case. PR-URL: https://github.com/nodejs/node/pull/9000 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Ben Noordhuis --- src/udp_wrap.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/udp_wrap.cc b/src/udp_wrap.cc index 57238534c4a30e..d8480f5ebd1bf9 100644 --- a/src/udp_wrap.cc +++ b/src/udp_wrap.cc @@ -342,7 +342,6 @@ void UDPWrap::RecvStop(const FunctionCallbackInfo& args) { } -// TODO(bnoordhuis) share with StreamWrap::AfterWrite() in stream_wrap.cc void UDPWrap::OnSend(uv_udp_send_t* req, int status) { SendWrap* req_wrap = static_cast(req->data); if (req_wrap->have_callback()) {