contextify: use CHECK instead of if

I was walking through the vm changes and saw this particular `if` check interesting. In case `ctx` is empty it's going to fail later anyways. So, instead of putting an `if` check there; option a - use CHECK option b - do nothing Considering the developer wanted to make sure `ctx` is not empty, `CHECK` option looked more convenient. PR-URL: #3125 Reviewed-By: Ben Noordhuis <[email protected]>
nodejs · Oct 2, 2015 · e561585 · e561585
1 parent 4c59407
commit e561585
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/node_contextify.cc b/src/node_contextify.cc
@@ -216,8 +216,9 @@ class ContextifyContext {
     object_template->SetHandler(config);
 
     Local<Context> ctx = Context::New(env->isolate(), nullptr, object_template);
-    if (!ctx.IsEmpty())
-      ctx->SetSecurityToken(env->context()->GetSecurityToken());
+
+    CHECK(!ctx.IsEmpty());
+    ctx->SetSecurityToken(env->context()->GetSecurityToken());
 
     env->AssignToContext(ctx);