buffer: allow .write() offset to be at buffer end

Do not throw if the offset passed to `buf.write()` points to the end of the buffer. Fixes: #8127 PR-URL: #8154 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
nodejs · Aug 24, 2016 · e371545 · e371545
1 parent c2f5471
commit e371545
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/node_buffer.cc b/src/node_buffer.cc
@@ -714,7 +714,7 @@ void StringWrite(const FunctionCallbackInfo<Value>& args) {
   size_t max_length;
 
   CHECK_NOT_OOB(ParseArrayIndex(args[1], 0, &offset));
-  if (offset >= ts_obj_length)
+  if (offset > ts_obj_length)
     return env->ThrowRangeError("Offset is out of bounds");
 
   CHECK_NOT_OOB(ParseArrayIndex(args[2], ts_obj_length - offset, &max_length));

diff --git a/test/parallel/test-buffer-alloc.js b/test/parallel/test-buffer-alloc.js
@@ -358,6 +358,12 @@ writeTest.write('e', 3, 'ascii');
 writeTest.write('j', 4, 'ascii');
 assert.equal(writeTest.toString(), 'nodejs');
 
+// Offset points to the end of the buffer
+// (see https://github.com/nodejs/node/issues/8127).
+assert.doesNotThrow(() => {
+  Buffer.alloc(1).write('', 1, 0);
+});
+
 // ASCII slice test
 {
   const asciiString = 'hello world';