From e2f564821e0204f3522e936baa8512a4f12128d1 Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Tue, 17 Oct 2017 16:22:22 -0700
Subject: [PATCH] test: make test-process-env-symbols agnostic
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Do not check the error message if it is generated by the JavaScript
engine (V8, ChakraCore, etc.). Do confirm that it is a `TypeError`.

PR-URL: https://github.com/nodejs/node/pull/16272
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
---
 test/parallel/test-process-env-symbols.js | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/test/parallel/test-process-env-symbols.js b/test/parallel/test-process-env-symbols.js
index 13a9cd4df30ae6..51e8eafbeacf51 100644
--- a/test/parallel/test-process-env-symbols.js
+++ b/test/parallel/test-process-env-symbols.js
@@ -3,20 +3,23 @@ require('../common');
 
 const assert = require('assert');
 const symbol = Symbol('sym');
-const errRegExp = /^TypeError: Cannot convert a Symbol value to a string$/;
 
 // Verify that getting via a symbol key returns undefined.
 assert.strictEqual(process.env[symbol], undefined);
 
 // Verify that assigning via a symbol key throws.
+// The message depends on the JavaScript engine and so will be different between
+// different JavaScript engines. Confirm that the `Error` is a `TypeError` only.
 assert.throws(() => {
   process.env[symbol] = 42;
-}, errRegExp);
+}, TypeError);
 
 // Verify that assigning a symbol value throws.
+// The message depends on the JavaScript engine and so will be different between
+// different JavaScript engines. Confirm that the `Error` is a `TypeError` only.
 assert.throws(() => {
   process.env.foo = symbol;
-}, errRegExp);
+}, TypeError);
 
 // Verify that using a symbol with the in operator returns false.
 assert.strictEqual(symbol in process.env, false);