Skip to content

Commit

Permalink
doc: tweak macOS-firewall note position
Browse files Browse the repository at this point in the history
Move the macOS-firewall note to the end of "Building Node.js"
and above "Running Tests".

I think it's more reasonable when user prepare to build node
step by step. Just read and build from top to end in case ignore
the note.

PR-URL: #22440
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
  • Loading branch information
ZYSzys authored and targos committed Sep 3, 2018
1 parent 9d246f9 commit e254130
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,17 +135,6 @@ More Developer Tools...`. This step will install `clang`, `clang++`, and
If the path to your build directory contains a space, the build will likely
fail.

After building, setting up [firewall rules](tools/macos-firewall.sh) can avoid
popups asking to accept incoming network connections when running tests.

Running the following script on macOS will add the firewall rules for the
executable `node` in the `out` directory and the symbolic `node` link in the
project's root directory.

```console
$ sudo ./tools/macos-firewall.sh
```

On FreeBSD and OpenBSD, you may also need:
* libexecinfo

Expand All @@ -169,6 +158,17 @@ for more information.
Note that the above requires that `python` resolve to Python 2.6 or 2.7
and not a newer version.

After building, setting up [firewall rules](tools/macos-firewall.sh) can avoid
popups asking to accept incoming network connections when running tests.

Running the following script on macOS will add the firewall rules for the
executable `node` in the `out` directory and the symbolic `node` link in the
project's root directory.

```console
$ sudo ./tools/macos-firewall.sh
```

#### Running Tests

To verify the build:
Expand Down

0 comments on commit e254130

Please sign in to comment.