http: move utcDate to internal/http.js

Backport-PR-URL: #14813 Backport-Reviewed-By: Anna Henningsen <[email protected]> Backport-Reviewed-By: Timothy Gu <[email protected]> PR-URL: #14239 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · Aug 14, 2017 · e0001dc · e0001dc
1 parent 9e51802
commit e0001dc
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 17 deletions.
diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -23,9 +23,9 @@
 
 const assert = require('assert').ok;
 const Stream = require('stream');
-const timers = require('timers');
 const util = require('util');
 const internalUtil = require('internal/util');
+const internalHttp = require('internal/http');
 const Buffer = require('buffer').Buffer;
 const common = require('_http_common');
 const checkIsHttpToken = common._checkIsHttpToken;
@@ -36,6 +36,7 @@ const nextTick = require('internal/process/next_tick').nextTick;
 
 const CRLF = common.CRLF;
 const debug = common.debug;
+const utcDate = internalHttp.utcDate;
 
 var RE_FIELDS =
   /^(?:Connection|Transfer-Encoding|Content-Length|Date|Expect|Trailer|Upgrade)$/i;
@@ -63,24 +64,8 @@ function isCookieField(s) {
   return true;
 }
 
-var dateCache;
-function utcDate() {
-  if (!dateCache) {
-    var d = new Date();
-    dateCache = d.toUTCString();
-    timers.enroll(utcDate, 1000 - d.getMilliseconds());
-    timers._unrefActive(utcDate);
-  }
-  return dateCache;
-}
-utcDate._onTimeout = function _onTimeout() {
-  dateCache = undefined;
-};
-
-
 function noopPendingOutput(amount) {}
 
-
 function OutgoingMessage() {
   Stream.call(this);
 

diff --git a/lib/internal/http.js b/lib/internal/http.js
@@ -1,10 +1,27 @@
 'use strict';
 
+const timers = require('timers');
+
+var dateCache;
+function utcDate() {
+  if (!dateCache) {
+    const d = new Date();
+    dateCache = d.toUTCString();
+    timers.enroll(utcDate, 1000 - d.getMilliseconds());
+    timers._unrefActive(utcDate);
+  }
+  return dateCache;
+}
+utcDate._onTimeout = function() {
+  dateCache = undefined;
+};
+
 function ondrain() {
   if (this._httpMessage) this._httpMessage.emit('drain');
 }
 
 module.exports = {
   outHeadersKey: Symbol('outHeadersKey'),
   ondrain,
+  utcDate
 };