crypto: prevent Sign::SignFinal from crashing

The validation logic could be tricked into assuming an option was valid using malicious getters, leading to an invalid value being passed to the C++ layer, thus crashing the process. PR-URL: #21815 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
nodejs · Jul 18, 2018 · d9825c7 · d9825c7
1 parent 576f1ea
commit d9825c7
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/internal/crypto/sig.js b/lib/internal/crypto/sig.js
@@ -57,10 +57,11 @@ function getSaltLength(options) {
 
 function getIntOption(name, defaultValue, options) {
   if (options.hasOwnProperty(name)) {
-    if (options[name] === options[name] >> 0) {
-      return options[name];
+    const value = options[name];
+    if (value === value >> 0) {
+      return value;
     } else {
-      throw new ERR_INVALID_OPT_VALUE(name, options[name]);
+      throw new ERR_INVALID_OPT_VALUE(name, value);
     }
   }
   return defaultValue;