doc,lib: prepare for stricter multi-line array linting

We're about to turn on a requirement for dangling commas. PR-URL: #37088 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs · Sep 4, 2021 · d56e826 · d56e826
1 parent 9db3304
commit d56e826
Show file tree

Hide file tree

Showing 28 changed files with 48 additions and 48 deletions.
diff --git a/doc/api/child_process.md b/doc/api/child_process.md
@@ -1326,7 +1326,7 @@ const subprocess = spawn(
     '-c',
     `node -e "setInterval(() => {
       console.log(process.pid, 'is alive')
-    }, 500);"`
+    }, 500);"`,
   ], {
     stdio: ['inherit', 'inherit', 'inherit']
   }
@@ -1661,7 +1661,7 @@ const subprocess = child_process.spawn('ls', {
   stdio: [
     0, // Use parent's stdin for child.
     'pipe', // Pipe child's stdout to parent.
-    fs.openSync('err.out', 'w') // Direct child's stderr to a file.
+    fs.openSync('err.out', 'w'), // Direct child's stderr to a file.
   ]
 });
 

diff --git a/doc/api/dns.md b/doc/api/dns.md
@@ -160,7 +160,7 @@ section if a custom port is used.
   '4.4.4.4',
   '2001:4860:4860::8888',
   '4.4.4.4:1053',
-  '[2001:4860:4860::8888]:1053'
+  '[2001:4860:4860::8888]:1053',
 ]
 ```
 
@@ -666,7 +666,7 @@ dns.setServers([
   '4.4.4.4',
   '[2001:4860:4860::8888]',
   '4.4.4.4:1053',
-  '[2001:4860:4860::8888]:1053'
+  '[2001:4860:4860::8888]:1053',
 ]);
 ```
 
@@ -773,7 +773,7 @@ section if a custom port is used.
   '4.4.4.4',
   '2001:4860:4860::8888',
   '4.4.4.4:1053',
-  '[2001:4860:4860::8888]:1053'
+  '[2001:4860:4860::8888]:1053',
 ]
 ```
 
@@ -1184,7 +1184,7 @@ dnsPromises.setServers([
   '4.4.4.4',
   '[2001:4860:4860::8888]',
   '4.4.4.4:1053',
-  '[2001:4860:4860::8888]:1053'
+  '[2001:4860:4860::8888]:1053',
 ]);
 ```
 

diff --git a/doc/api/os.md b/doc/api/os.md
@@ -115,7 +115,7 @@ The properties included on each object include:
       idle: 1070905480,
       irq: 20
     }
-  }
+  },
 ]
 ```
 

diff --git a/doc/api/url.md b/doc/api/url.md
@@ -573,7 +573,7 @@ with [`JSON.stringify()`][].
 ```js
 const myURLs = [
   new URL('https://www.example.com'),
-  new URL('https://test.example.org')
+  new URL('https://test.example.org'),
 ];
 console.log(JSON.stringify(myURLs));
 // Prints ["https://www.example.com/","https://test.example.org/"]
@@ -710,7 +710,7 @@ let params;
 params = new URLSearchParams([
   ['user', 'abc'],
   ['query', 'first'],
-  ['query', 'second']
+  ['query', 'second'],
 ]);
 console.log(params.toString());
 // Prints 'user=abc&query=first&query=second'
@@ -735,7 +735,7 @@ console.log(params.toString());
 
 // Each key-value pair must have exactly two elements
 new URLSearchParams([
-  ['user', 'abc', 'error']
+  ['user', 'abc', 'error'],
 ]);
 // Throws TypeError [ERR_INVALID_TUPLE]:
 //        Each query pair must be an iterable [name, value] tuple

diff --git a/lib/assert.js b/lib/assert.js
@@ -91,7 +91,7 @@ const meta = [
   '\\u000f', '\\u0010', '\\u0011', '\\u0012', '\\u0013',
   '\\u0014', '\\u0015', '\\u0016', '\\u0017', '\\u0018',
   '\\u0019', '\\u001a', '\\u001b', '\\u001c', '\\u001d',
-  '\\u001e', '\\u001f'
+  '\\u001e', '\\u001f',
 ];
 
 const escapeFn = (str) => meta[StringPrototypeCharCodeAt(str, 0)];
@@ -268,7 +268,7 @@ function parseCode(code, offset) {
     node.node.start,
     StringPrototypeReplace(StringPrototypeSlice(code,
                                                 node.node.start, node.node.end),
-                           escapeSequencesRegExp, escapeFn)
+                           escapeSequencesRegExp, escapeFn),
   ];
 }
 

diff --git a/lib/internal/bootstrap/loaders.js b/lib/internal/bootstrap/loaders.js
@@ -103,7 +103,7 @@ const internalBindingAllowlist = new SafeSet([
   'util',
   'uv',
   'v8',
-  'zlib'
+  'zlib',
 ]);
 
 // Set up process.binding() and process._linkedBinding().

diff --git a/lib/internal/bootstrap/pre_execution.js b/lib/internal/bootstrap/pre_execution.js
@@ -252,7 +252,7 @@ function initializeDeprecations() {
     'isSetIterator',
     'isTypedArray',
     'isUint8Array',
-    'isAnyArrayBuffer'
+    'isAnyArrayBuffer',
   ]) {
     utilBinding[name] = pendingDeprecation ?
       deprecate(types[name],

diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js
@@ -532,7 +532,7 @@ const consoleMethods = {
         }
       }
       return final([
-        iterKey, keyKey, valuesKey
+        iterKey, keyKey, valuesKey,
       ], [
         getIndexArray(length),
         keys,

diff --git a/lib/internal/crypto/random.js b/lib/internal/crypto/random.js
@@ -223,7 +223,7 @@ function handleError(ex, buf) {
 
 const kHexDigits = [
   48, 49, 50, 51, 52, 53, 54, 55,
-  56, 57, 97, 98, 99, 100, 101, 102
+  56, 57, 97, 98, 99, 100, 101, 102,
 ];
 
 const kBatchSize = 128;

diff --git a/lib/internal/encoding.js b/lib/internal/encoding.js
@@ -286,7 +286,7 @@ const encodings = new SafeMap([
   ['windows-949', 'euc-kr'],
   ['utf-16be', 'utf-16be'],
   ['utf-16le', 'utf-16le'],
-  ['utf-16', 'utf-16le']
+  ['utf-16', 'utf-16le'],
 ]);
 
 // Unfortunately, String.prototype.trim also removes non-ascii whitespace,

diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -70,7 +70,7 @@ const kTypes = [
   'Object',
   'boolean',
   'bigint',
-  'symbol'
+  'symbol',
 ];
 
 const MainContextError = Error;

diff --git a/lib/internal/freeze_intrinsics.js b/lib/internal/freeze_intrinsics.js
@@ -212,7 +212,7 @@ module.exports = function() {
     WebAssembly.CompileError.prototype,
     WebAssembly.LinkError.prototype,
     WebAssembly.RuntimeError.prototype,
-    SharedArrayBuffer.prototype
+    SharedArrayBuffer.prototype,
   ];
   const intrinsics = [
     // Anonymous Intrinsics
@@ -326,7 +326,7 @@ module.exports = function() {
     BigInt,
     Atomics,
     WebAssembly,
-    SharedArrayBuffer
+    SharedArrayBuffer,
   ];
 
   if (typeof Intl !== 'undefined') {

diff --git a/lib/internal/http2/util.js b/lib/internal/http2/util.js
@@ -103,7 +103,7 @@ const kValidPseudoHeaders = new Set([
   HTTP2_HEADER_AUTHORITY,
   HTTP2_HEADER_SCHEME,
   HTTP2_HEADER_PATH,
-  HTTP2_HEADER_PROTOCOL
+  HTTP2_HEADER_PROTOCOL,
 ]);
 
 // This set contains headers that are permitted to have only a single
@@ -147,7 +147,7 @@ const kSingleValueHeaders = new Set([
   HTTP2_HEADER_TK,
   HTTP2_HEADER_UPGRADE_INSECURE_REQUESTS,
   HTTP2_HEADER_USER_AGENT,
-  HTTP2_HEADER_X_CONTENT_TYPE_OPTIONS
+  HTTP2_HEADER_X_CONTENT_TYPE_OPTIONS,
 ]);
 
 // The HTTP methods in this set are specifically defined as assigning no
@@ -157,7 +157,7 @@ const kSingleValueHeaders = new Set([
 const kNoPayloadMethods = new Set([
   HTTP2_METHOD_DELETE,
   HTTP2_METHOD_GET,
-  HTTP2_METHOD_HEAD
+  HTTP2_METHOD_HEAD,
 ]);
 
 // The following ArrayBuffer instances are used to share memory more efficiently

diff --git a/lib/internal/main/print_help.js b/lib/internal/main/print_help.js
@@ -60,13 +60,13 @@ const envVars = new SafeMap(ArrayPrototypeConcat([
   ['NODE_V8_COVERAGE', { helpText: 'directory to output v8 coverage JSON ' +
     'to' }],
   ['UV_THREADPOOL_SIZE', { helpText: 'sets the number of threads used in ' +
-    'libuv\'s threadpool' }]
+    'libuv\'s threadpool' }],
 ], hasIntl ? [
   ['NODE_ICU_DATA', { helpText: 'data path for ICU (Intl object) data' +
-    hasSmallICU ? '' : ' (will extend linked-in data)' }]
+    hasSmallICU ? '' : ' (will extend linked-in data)' }],
 ] : []), (hasNodeOptions ? [
   ['NODE_OPTIONS', { helpText: 'set CLI options in the environment via a ' +
-    'space-separated list' }]
+    'space-separated list' }],
 ] : []), hasCrypto ? [
   ['OPENSSL_CONF', { helpText: 'load OpenSSL configuration from file' }],
   ['SSL_CERT_DIR', { helpText: 'sets OpenSSL\'s directory of trusted ' +

diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js
@@ -196,7 +196,7 @@ let wrap = function(script) {
 
 const wrapper = [
   '(function (exports, require, module, __filename, __dirname) { ',
-  '\n});'
+  '\n});',
 ];
 
 let wrapperProxy = new Proxy(wrapper, {

diff --git a/lib/internal/process/per_thread.js b/lib/internal/process/per_thread.js
@@ -138,7 +138,7 @@ function wrapProcessMethods(binding) {
 
     return [
       hrValues[0] * 0x100000000 + hrValues[1],
-      hrValues[2]
+      hrValues[2],
     ];
   }
 

diff --git a/lib/internal/querystring.js b/lib/internal/querystring.js
@@ -33,7 +33,7 @@ const isHexTable = new Int8Array([
   0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
   0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
   0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
-  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0  // ... 256
+  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,  // ... 256
 ]);
 
 /**

diff --git a/lib/internal/streams/pipeline.js b/lib/internal/streams/pipeline.js
@@ -221,7 +221,7 @@ function pipeline(...streams) {
               pt.end(val);
             }, (err) => {
               pt.destroy(err);
-            }
+            },
           ]);
         } else if (isIterable(ret, true)) {
           finishCount++;

diff --git a/lib/internal/tty.js b/lib/internal/tty.js
@@ -77,7 +77,7 @@ const TERM_ENVS_REG_EXP = [
   /^rxvt/,
   /^screen/,
   /^xterm/,
-  /^vt100/
+  /^vt100/,
 ];
 
 let warned = false;

diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -844,7 +844,7 @@ const noEscape = new Int8Array([
   0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, // 0x40 - 0x4F
   1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 1, // 0x50 - 0x5F
   0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, // 0x60 - 0x6F
-  1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0  // 0x70 - 0x7F
+  1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0,  // 0x70 - 0x7F
 ]);
 
 // Special version of hexTable that uses `+` for U+0020 SPACE.

diff --git a/lib/internal/util/comparisons.js b/lib/internal/util/comparisons.js
@@ -142,7 +142,7 @@ function isIdenticalTypedArrayType(a, b) {
     isBigInt64Array,
     isBigUint64Array,
     isUint8ClampedArray,
-    isUint8Array
+    isUint8Array,
   ]) {
     if (check(a)) {
       return check(b);

diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
@@ -695,7 +695,7 @@ function formatProxy(ctx, proxy, recurseTimes) {
   ctx.indentationLvl += 2;
   const res = [
     formatValue(ctx, proxy[0], recurseTimes),
-    formatValue(ctx, proxy[1], recurseTimes)
+    formatValue(ctx, proxy[1], recurseTimes),
   ];
   ctx.indentationLvl -= 2;
   return reduceToSingleString(
@@ -1513,7 +1513,7 @@ function formatTypedArray(value, length, ctx, ignored, recurseTimes) {
       'length',
       'byteLength',
       'byteOffset',
-      'buffer'
+      'buffer',
     ]) {
       const str = formatValue(ctx, value[key], recurseTimes, true);
       output.push(`[${key}]: ${str}`);
@@ -1591,7 +1591,7 @@ function formatMapIterInner(ctx, recurseTimes, entries, state) {
       const pos = i * 2;
       const res = [
         formatValue(ctx, entries[pos], recurseTimes),
-        formatValue(ctx, entries[pos + 1], recurseTimes)
+        formatValue(ctx, entries[pos + 1], recurseTimes),
       ];
       output[i] = reduceToSingleString(
         ctx, res, '', ['[', ']'], kArrayExtrasType, recurseTimes);
@@ -1641,7 +1641,7 @@ function formatPromise(ctx, value, recurseTimes) {
     output = [
       state === kRejected ?
         `${ctx.stylize('<rejected>', 'special')} ${str}` :
-        str
+        str,
     ];
   }
   return output;

diff --git a/lib/internal/v8_prof_processor.js b/lib/internal/v8_prof_processor.js
@@ -20,7 +20,7 @@ const scriptFiles = [
   'internal/deps/v8/tools/arguments',
   'internal/deps/v8/tools/tickprocessor',
   'internal/deps/v8/tools/SourceMap',
-  'internal/deps/v8/tools/tickprocessor-driver'
+  'internal/deps/v8/tools/tickprocessor-driver',
 ];
 let script = '';
 

diff --git a/lib/perf_hooks.js b/lib/perf_hooks.js
@@ -94,7 +94,7 @@ const observerableTypes = [
   'gc',
   'function',
   'http2',
-  'http'
+  'http',
 ];
 
 const IDX_STREAM_STATS_ID = 0;

diff --git a/lib/querystring.js b/lib/querystring.js
@@ -74,7 +74,7 @@ const unhexTable = new Int8Array([
   -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
   -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
   -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
-  -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1  // ... 255
+  -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,  // ... 255
 ]);
 /**
  * A safe fast alternative to decodeURIComponent
@@ -152,7 +152,7 @@ const noEscape = new Int8Array([
   0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, // 64 - 79
   1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 1, // 80 - 95
   0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, // 96 - 111
-  1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 1, 0  // 112 - 127
+  1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 1, 0,  // 112 - 127
 ]);
 
 /**

diff --git a/lib/readline.js b/lib/readline.js
@@ -144,7 +144,7 @@ function Interface(input, output, completer, terminal) {
   this.escapeCodeTimeout = ESCAPE_CODE_TIMEOUT;
   this.tabSize = 8;
 
-  FunctionPrototypeCall(EventEmitter, this,);
+  FunctionPrototypeCall(EventEmitter, this);
   let history;
   let historySize;
   let removeHistoryDuplicates = false;

diff --git a/lib/repl.js b/lib/repl.js
@@ -1631,7 +1631,7 @@ function addCommonWords(completionGroups) {
     'debugger', 'default', 'delete', 'do', 'else', 'export', 'false',
     'finally', 'for', 'function', 'if', 'import', 'in', 'instanceof', 'let',
     'new', 'null', 'return', 'switch', 'this', 'throw', 'true', 'try',
-    'typeof', 'var', 'void', 'while', 'with', 'yield'
+    'typeof', 'var', 'void', 'while', 'with', 'yield',
   ]);
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -115,7 +115,7 @@ The properties included on each object include: @@
           idle: 1070905480,
           irq: 20
         }
-      }
+      },
     ]
     ```
@@ Expand Down @@