From d55599f4d83b85f60280b43803060cb9e50f34c9 Mon Sep 17 00:00:00 2001 From: Benjamin Gruenbaum Date: Sun, 20 Mar 2016 15:13:51 +0200 Subject: [PATCH] dns: use template literals Prefer the use of template string literals over string concatenation in the dns module, makes dns consistent with other modules basically doing https://github.com/nodejs/node/pull/5778 for it. PR-URL: https://github.com/nodejs/node/pull/5809 Reviewed-By: James M Snell --- lib/dns.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/dns.js b/lib/dns.js index 6683eacf14008f..5a87b8c865f616 100644 --- a/lib/dns.js +++ b/lib/dns.js @@ -23,7 +23,8 @@ function errnoException(err, syscall, hostname) { } var ex = null; if (typeof err === 'string') { // c-ares error code. - ex = new Error(syscall + ' ' + err + (hostname ? ' ' + hostname : '')); + const errHost = hostname ? ' ' + hostname : ''; + ex = new Error(`${syscall} ${err}${errHost}`); ex.code = err; ex.errno = err; ex.syscall = syscall; @@ -268,7 +269,7 @@ exports.resolve = function(hostname, type_, callback_) { if (typeof resolver === 'function') { return resolver(hostname, callback); } else { - throw new Error('Unknown type "' + type_ + '"'); + throw new Error(`Unknown type "${type_}"`); } }; @@ -306,7 +307,7 @@ exports.setServers = function(servers) { if (ver) return newSet.push([ver, s]); - throw new Error('IP address is not properly formatted: ' + serv); + throw new Error(`IP address is not properly formatted: ${serv}`); }); var r = cares.setServers(newSet); @@ -316,8 +317,7 @@ exports.setServers = function(servers) { cares.setServers(orig.join(',')); var err = cares.strerror(r); - throw new Error('c-ares failed to set servers: "' + err + - '" [' + servers + ']'); + throw new Error(`c-ares failed to set servers: "${err}" [${servers}]`); } };