repl: remove dead code

The .scope command was used only in the old debugger. Since that's not part of core anymore it's does not have any use. I tried to replicate the expected behavior but it even results in just exiting the repl immediately when using the completion similar to the removed test case. PR-URL: #30907 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Dec 17, 2019 · d549dae · d549dae
1 parent 69aaab0
commit d549dae
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 57 deletions.
diff --git a/lib/repl.js b/lib/repl.js
@@ -43,7 +43,6 @@
 'use strict';
 
 const {
-  ArrayIsArray,
   MathMax,
   NumberIsNaN,
   ObjectAssign,
@@ -1277,40 +1276,23 @@ function complete(line, callback) {
       // Resolve expr and get its completions.
       const memberGroups = [];
       if (!expr) {
-        // If context is instance of vm.ScriptContext
         // Get global vars synchronously
-        if (this.useGlobal || vm.isContext(this.context)) {
-          completionGroups.push(getGlobalLexicalScopeNames(this[kContextId]));
-          let contextProto = this.context;
-          while (contextProto = ObjectGetPrototypeOf(contextProto)) {
-            completionGroups.push(
-              filteredOwnPropertyNames.call(this, contextProto));
-          }
-          const contextOwnNames =
-            filteredOwnPropertyNames.call(this, this.context);
-          if (!this.useGlobal) {
-            // When the context is not `global`, builtins are not own
-            // properties of it.
-            contextOwnNames.push(...globalBuiltins);
-          }
-          completionGroups.push(contextOwnNames);
-          if (filter !== '') addCommonWords(completionGroups);
-          completionGroupsLoaded();
-        } else {
-          this.eval('.scope', this.context, 'repl', function ev(err, globals) {
-            if (err || !ArrayIsArray(globals)) {
-              if (filter !== '') addCommonWords(completionGroups);
-            } else if (ArrayIsArray(globals[0])) {
-              // Add grouped globals
-              for (let n = 0; n < globals.length; n++)
-                completionGroups.push(globals[n]);
-            } else {
-              completionGroups.push(globals);
-              if (filter !== '') addCommonWords(completionGroups);
-            }
-            completionGroupsLoaded();
-          });
+        completionGroups.push(getGlobalLexicalScopeNames(this[kContextId]));
+        let contextProto = this.context;
+        while (contextProto = ObjectGetPrototypeOf(contextProto)) {
+          completionGroups.push(
+            filteredOwnPropertyNames.call(this, contextProto));
+        }
+        const contextOwnNames =
+          filteredOwnPropertyNames.call(this, this.context);
+        if (!this.useGlobal) {
+          // When the context is not `global`, builtins are not own
+          // properties of it.
+          contextOwnNames.push(...globalBuiltins);
         }
+        completionGroups.push(contextOwnNames);
+        if (filter !== '') addCommonWords(completionGroups);
+        completionGroupsLoaded();
       } else {
         const evalExpr = `try { ${expr} } catch {}`;
         this.eval(evalExpr, this.context, 'repl', (e, obj) => {

diff --git a/test/parallel/test-repl-eval-scope.js b/test/parallel/test-repl-eval-scope.js