lib: make String(global) === '[object global]'

This inadvertently changed to `[object Object]` with the V8 upgrade in 8a24728...96933df. Use `Symbol.toStringTag` to undo this particular change. Fixes: #9274 PR-URL: #9279 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
nodejs · Nov 2, 2016 · d24bd20 · d24bd20
1 parent 53520f0
commit d24bd20
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/internal/bootstrap_node.js b/lib/internal/bootstrap_node.js
@@ -188,6 +188,12 @@
   }
 
   function setupGlobalVariables() {
+    Object.defineProperty(global, Symbol.toStringTag, {
+      value: 'global',
+      writable: false,
+      enumerable: false,
+      configurable: true
+    });
     global.process = process;
     const util = NativeModule.require('util');
 

diff --git a/test/parallel/test-global.js b/test/parallel/test-global.js
@@ -21,3 +21,5 @@ const fooBar = module.fooBar;
 assert.strictEqual('foo', fooBar.foo, 'x -> global.x in sub level not working');
 
 assert.strictEqual('bar', fooBar.bar, 'global.x -> x in sub level not working');
+
+assert.strictEqual(Object.prototype.toString.call(global), '[object global]');