os: move process.binding('os') to internalBinding

PR-URL: #25087 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: #25446
nodejs · Jan 14, 2019 · d197105 · d197105
1 parent 445ba9f
commit d197105
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 3 deletions.
diff --git a/lib/internal/bootstrap/loaders.js b/lib/internal/bootstrap/loaders.js
@@ -93,6 +93,7 @@ const internalBindingWhitelist = [
   'inspector',
   'js_stream',
   'natives',
+  'os',
   'pipe_wrap',
   'process_wrap',
   'signal_wrap',

diff --git a/lib/os.js b/lib/os.js
@@ -44,7 +44,7 @@ const {
   getUptime,
   isBigEndian,
   setPriority: _setPriority
-} = process.binding('os');
+} = internalBinding('os');
 
 function getCheckedFunction(fn) {
   return function checkError(...args) {

diff --git a/src/node_os.cc b/src/node_os.cc
@@ -467,4 +467,4 @@ void Initialize(Local<Object> target,
 }  // namespace os
 }  // namespace node
 
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(os, node::os::Initialize)
+NODE_MODULE_CONTEXT_AWARE_INTERNAL(os, node::os::Initialize)
diff --git a/test/parallel/test-os-checked-function.js b/test/parallel/test-os-checked-function.js
@@ -1,7 +1,11 @@
 'use strict';
+// Flags: --expose_internals
+
+const { internalBinding } = require('internal/test/binding');
+
 // Monkey patch the os binding before requiring any other modules, including
 // common, which requires the os module.
-process.binding('os').getHomeDirectory = function(ctx) {
+internalBinding('os').getHomeDirectory = function(ctx) {
   ctx.syscall = 'foo';
   ctx.code = 'bar';
   ctx.message = 'baz';

diff --git a/test/parallel/test-process-binding-internalbinding-whitelist.js b/test/parallel/test-process-binding-internalbinding-whitelist.js
@@ -18,3 +18,4 @@ assert(process.binding('js_stream'));
 assert(process.binding('buffer'));
 assert(process.binding('fs'));
 assert(process.binding('inspector'));
+assert(process.binding('os'));