http2: close fd in doSendFileFD()

This commit closes the file descriptor in two code paths that return from doSendFileFD(). PR-URL: #23047 Fixes: #23029 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
nodejs · Sep 27, 2018 · d1826fe · d1826fe
1 parent 4cda83d
commit d1826fe
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -2149,6 +2149,7 @@ function doSendFileFD(session, options, fd, headers, streamOptions, err, stat) {
         isDirectory) {
       const err = isDirectory ?
         new ERR_HTTP2_SEND_FILE() : new ERR_HTTP2_SEND_FILE_NOSEEK();
+      tryClose(fd);
       if (onError)
         onError(err);
       else
@@ -2179,6 +2180,7 @@ function doSendFileFD(session, options, fd, headers, streamOptions, err, stat) {
   if ((typeof options.statCheck === 'function' &&
        options.statCheck.call(this, stat, headers) === false) ||
        (this[kState].flags & STREAM_FLAGS_HEADERS_SENT)) {
+    tryClose(fd);
     return;
   }