buffer: optimize byteLength for common encodings

PR-URL: #54342 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Oct 2, 2024 · d04246a · d04246a
1 parent 8c8708c
commit d04246a
Showing 1 changed file with 15 additions and 6 deletions.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -780,13 +780,22 @@ function byteLength(string, encoding) {
   if (len === 0)
     return 0;
 
-  if (encoding) {
-    const ops = getEncodingOps(encoding);
-    if (ops) {
-      return ops.byteLength(string);
-    }
+  if (!encoding || encoding === 'utf8') {
+    return byteLengthUtf8(string);
+  }
+
+  if (encoding === 'ascii') {
+    return len;
   }
-  return byteLengthUtf8(string);
+
+  const ops = getEncodingOps(encoding);
+  if (ops === undefined) {
+    // TODO (ronag): Makes more sense to throw here.
+    // throw new ERR_UNKNOWN_ENCODING(encoding);
+    return byteLengthUtf8(string);
+  }
+
+  return ops.byteLength(string);
 }
 
 Buffer.byteLength = byteLength;