Skip to content

Commit

Permalink
doc: clarify experimental API elements in vm.md
Browse files Browse the repository at this point in the history
Remove redundant "should not be considered stable" (it immediately
follows a clause saying that it is "experimental") and replace with a
more clear (to me, at least) statement that we don't recommend using the
feature in production.

PR-URL: #35594
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
Trott committed Oct 19, 2020
1 parent 7afe3af commit ce03a18
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions doc/api/vm.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ changes:
* `importModuleDynamically` {Function} Called during evaluation of this module
when `import()` is called. If this option is not specified, calls to
`import()` will reject with [`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING`][].
This option is part of the experimental modules API, and should not be
considered stable.
This option is part of the experimental modules API. We do not recommend
using it in a production environment.
* `specifier` {string} specifier passed to `import()`
* `script` {vm.Script}
* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
Expand Down Expand Up @@ -981,8 +981,8 @@ changes:
* `importModuleDynamically` {Function} Called during evaluation of this module
when `import()` is called. If this option is not specified, calls to
`import()` will reject with [`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING`][].
This option is part of the experimental modules API, and should not be
considered stable.
This option is part of the experimental modules API. We do not recommend
using it in a production environment.
* `specifier` {string} specifier passed to `import()`
* `script` {vm.Script}
* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
Expand Down Expand Up @@ -1079,8 +1079,8 @@ changes:
* `importModuleDynamically` {Function} Called during evaluation of this module
when `import()` is called. If this option is not specified, calls to
`import()` will reject with [`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING`][].
This option is part of the experimental modules API, and should not be
considered stable.
This option is part of the experimental modules API. We do not recommend
using it in a production environment.
* `specifier` {string} specifier passed to `import()`
* `script` {vm.Script}
* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
Expand Down Expand Up @@ -1158,8 +1158,8 @@ changes:
* `importModuleDynamically` {Function} Called during evaluation of this module
when `import()` is called. If this option is not specified, calls to
`import()` will reject with [`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING`][].
This option is part of the experimental modules API, and should not be
considered stable.
This option is part of the experimental modules API. We do not recommend
using it in a production environment.
* `specifier` {string} specifier passed to `import()`
* `script` {vm.Script}
* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
Expand Down

0 comments on commit ce03a18

Please sign in to comment.