From cc4a6ed645c414c299adb1a502f1954abad2aba0 Mon Sep 17 00:00:00 2001
From: cjihrig <cjihrig@gmail.com>
Date: Tue, 20 Aug 2019 17:19:48 -0400
Subject: [PATCH] test: use fs rimraf to refresh tmpdir

Now that the functionality is built into core, use it to
refresh the test suite's tmpdir.

PR-URL: https://github.com/nodejs/node/pull/30569
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
---
 test/common/tmpdir.js | 50 +------------------------------------------
 1 file changed, 1 insertion(+), 49 deletions(-)

diff --git a/test/common/tmpdir.js b/test/common/tmpdir.js
index 16d375afff06b1..0b8465bb22fc73 100644
--- a/test/common/tmpdir.js
+++ b/test/common/tmpdir.js
@@ -36,60 +36,12 @@ function rimrafSync(pathname, { spawn = true } = {}) {
     }
   }
 
-  try {
-    if (st.isDirectory())
-      rmdirSync(pathname, null);
-    else
-      fs.unlinkSync(pathname);
-  } catch (e) {
-    debug(e);
-    switch (e.code) {
-      case 'ENOENT':
-        // It's not there anymore. Work is done. Exiting.
-        return;
-
-      case 'EPERM':
-        // This can happen, try again with `rmdirSync`.
-        break;
-
-      case 'EISDIR':
-        // Got 'EISDIR' even after testing `st.isDirectory()`...
-        // Try again with `rmdirSync`.
-        break;
-
-      default:
-        throw e;
-    }
-    rmdirSync(pathname, e);
-  }
+  fs.rmdirSync(pathname, { recursive: true, maxRetries: 5 });
 
   if (fs.existsSync(pathname))
     throw new Error(`Unable to rimraf ${pathname}`);
 }
 
-function rmdirSync(p, originalEr) {
-  try {
-    fs.rmdirSync(p);
-  } catch (e) {
-    if (e.code === 'ENOTDIR')
-      throw originalEr;
-    if (e.code === 'ENOTEMPTY' || e.code === 'EEXIST' || e.code === 'EPERM') {
-      const enc = process.platform === 'linux' ? 'buffer' : 'utf8';
-      fs.readdirSync(p, enc).forEach((f) => {
-        if (f instanceof Buffer) {
-          const buf = Buffer.concat([Buffer.from(p), Buffer.from(path.sep), f]);
-          rimrafSync(buf);
-        } else {
-          rimrafSync(path.join(p, f));
-        }
-      });
-      fs.rmdirSync(p);
-      return;
-    }
-    throw e;
-  }
-}
-
 const testRoot = process.env.NODE_TEST_DIR ?
   fs.realpathSync(process.env.NODE_TEST_DIR) : path.resolve(__dirname, '..');