buffer: improve copy() performance

There is no need to create a slice when sourceEnd is out of bounds. PR-URL: #33214 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · May 11, 2020 · cae2051 · cae2051
1 parent eedc131
commit cae2051
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -257,7 +257,7 @@ function _copyActual(source, target, targetStart, sourceStart, sourceEnd) {
   if (nb > sourceLen)
     nb = sourceLen;
 
-  if (sourceStart !== 0 || sourceEnd !== source.length)
+  if (sourceStart !== 0 || sourceEnd < source.length)
     source = new Uint8Array(source.buffer, source.byteOffset + sourceStart, nb);
 
   target.set(source, targetStart);