repl: Empty command should be sent to eval function

This fixes a regression introduced in #6171 PR-URL: #11871 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs · Mar 17, 2017 · c7b6016 · c7b6016
1 parent f0d4237
commit c7b6016
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 6 deletions.
diff --git a/lib/repl.js b/lib/repl.js
@@ -422,12 +422,6 @@ function REPLServer(prompt,
           return;
         }
       }
-    } else {
-      // Print a new line when hitting enter.
-      if (!self.bufferedCommand) {
-        finish(null);
-        return;
-      }
     }
 
     const evalCmd = self.bufferedCommand + cmd + '\n';

diff --git a/test/parallel/test-repl-empty.js b/test/parallel/test-repl-empty.js
@@ -0,0 +1,29 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const repl = require('repl');
+
+{
+  let evalCalledWithExpectedArgs = false;
+
+  const options = {
+    eval: common.mustCall((cmd, context) => {
+      // Assertions here will not cause the test to exit with an error code
+      // so set a boolean that is checked in process.on('exit',...) instead.
+      evalCalledWithExpectedArgs = (cmd === '\n');
+    })
+  };
+
+  const r = repl.start(options);
+
+  try {
+    // Empty strings should be sent to the repl's eval function
+    r.write('\n');
+  } finally {
+    r.write('.exit\n');
+  }
+
+  process.on('exit', () => {
+    assert(evalCalledWithExpectedArgs);
+  });
+}