Skip to content

Commit

Permalink
crypto: don't build hardware engines
Browse files Browse the repository at this point in the history
Compile out hardware engines.  Most are stubs that dynamically load
the real driver but that poses a security liability when an attacker
is able to create a malicious DLL in one of the default search paths.

PR-URL: nodejs-private/node-private#70
Reviewed-By: James Snell <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Joao Reis <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
  • Loading branch information
bnoordhuis authored and rvagg committed Sep 27, 2016
1 parent 93b10fb commit c214e88
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions deps/openssl/openssl.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -1260,6 +1260,11 @@
# Microsoft's IIS, which seems to be ignoring whole ClientHello after
# seeing this extension.
'OPENSSL_NO_HEARTBEATS',

# Compile out hardware engines. Most are stubs that dynamically load
# the real driver but that poses a security liability when an attacker
# is able to create a malicious DLL in one of the default search paths.
'OPENSSL_NO_HW',
],
'openssl_default_defines_win': [
'MK1MF_BUILD',
Expand Down

0 comments on commit c214e88

Please sign in to comment.