wasi: improve use of primordials

PR-URL: #31212 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Jan 16, 2020 · bdaac04 · bdaac04
1 parent f7833ac
commit bdaac04
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/lib/wasi.js b/lib/wasi.js
@@ -2,10 +2,10 @@
 /* global WebAssembly */
 const {
   ArrayIsArray,
-  ArrayPrototypeForEach,
   ArrayPrototypeMap,
+  ArrayPrototypePush,
   FunctionPrototypeBind,
-  ObjectKeys,
+  ObjectEntries,
   Symbol,
 } = primordials;
 
@@ -40,7 +40,7 @@ class WASI {
       for (const key in env) {
         const value = env[key];
         if (value !== undefined)
-          envPairs.push(`${key}=${value}`);
+          ArrayPrototypePush(envPairs, `${key}=${value}`);
       }
     } else if (env !== undefined) {
       throw new ERR_INVALID_ARG_TYPE('options.env', 'Object', env);
@@ -49,10 +49,9 @@ class WASI {
     const preopenArray = [];
 
     if (typeof preopens === 'object' && preopens !== null) {
-      ArrayPrototypeForEach(ObjectKeys(preopens), (key) => {
-        preopenArray.push(String(key));
-        preopenArray.push(String(preopens[key]));
-      });
+      for (const [key, value] of ObjectEntries(preopens)) {
+        ArrayPrototypePush(preopenArray, String(key), String(value));
+      }
     } else if (preopens !== undefined) {
       throw new ERR_INVALID_ARG_TYPE('options.preopens', 'Object', preopens);
     }