lib: use <array>.push and <array>.unshift instead of <array>.concat

Using `push` and `unshift` methods is more performant than reassigning a new array created with `concat`. PR-URL: #37239 Reviewed-By: James M Snell <[email protected]>
nodejs · Feb 28, 2021 · bb81acc · bb81acc
1 parent a3e3156
commit bb81acc
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/lib/_http_common.js b/lib/_http_common.js
@@ -22,7 +22,7 @@
 'use strict';
 
 const {
-  ArrayPrototypeConcat,
+  ArrayPrototypePushApply,
   MathMin,
   Symbol,
   RegExpPrototypeTest,
@@ -66,7 +66,7 @@ function parserOnHeaders(headers, url) {
   // Once we exceeded headers limit - stop collecting them
   if (this.maxHeaderPairs <= 0 ||
       this._headers.length < this.maxHeaderPairs) {
-    this._headers = ArrayPrototypeConcat(this._headers, headers);
+    ArrayPrototypePushApply(this._headers, headers);
   }
   this._url += url;
 }

diff --git a/lib/internal/main/worker_thread.js b/lib/internal/main/worker_thread.js
@@ -4,8 +4,8 @@
 // message port.
 
 const {
-  ArrayPrototypeConcat,
   ArrayPrototypeForEach,
+  ArrayPrototypePushApply,
   ArrayPrototypeSplice,
   ObjectDefineProperty,
   PromisePrototypeCatch,
@@ -126,7 +126,7 @@ port.on('message', (message) => {
     loadPreloadModules();
     initializeFrozenIntrinsics();
     if (argv !== undefined) {
-      process.argv = ArrayPrototypeConcat(process.argv, argv);
+      ArrayPrototypePushApply(process.argv, argv);
     }
     publicWorker.parentPort = publicPort;
     publicWorker.workerData = workerData;

diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js
@@ -32,6 +32,7 @@ const {
   ArrayPrototypeSlice,
   ArrayPrototypeSplice,
   ArrayPrototypeUnshift,
+  ArrayPrototypeUnshiftApply,
   Boolean,
   Error,
   JSONParse,
@@ -1208,18 +1209,18 @@ Module._initPaths = function() {
     path.resolve(process.execPath, '..') :
     path.resolve(process.execPath, '..', '..');
 
-  let paths = [path.resolve(prefixDir, 'lib', 'node')];
+  const paths = [path.resolve(prefixDir, 'lib', 'node')];
 
   if (homeDir) {
     ArrayPrototypeUnshift(paths, path.resolve(homeDir, '.node_libraries'));
     ArrayPrototypeUnshift(paths, path.resolve(homeDir, '.node_modules'));
   }
 
   if (nodePath) {
-    paths = ArrayPrototypeConcat(ArrayPrototypeFilter(
+    ArrayPrototypeUnshiftApply(paths, ArrayPrototypeFilter(
       StringPrototypeSplit(nodePath, path.delimiter),
       Boolean
-    ), paths);
+    ));
   }
 
   modulePaths = paths;