inspector: add missing virtual destructor

This fixes a resource leak detected by a Coverity scan. PR-URL: #13198 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Aleksei Koziatinskii <[email protected]>
nodejs · May 28, 2017 · bb77cce · bb77cce
1 parent 145ab05
commit bb77cce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -195,7 +195,7 @@ class JsBindingsSessionDelegate : public InspectorSessionDelegate {
                      v8::WeakCallbackType::kParameter);
   }
 
-  virtual ~JsBindingsSessionDelegate() {
+  ~JsBindingsSessionDelegate() override {
     session_.Reset();
     receiver_.Reset();
     callback_.Reset();

diff --git a/src/inspector_agent.h b/src/inspector_agent.h
@@ -37,6 +37,7 @@ namespace inspector {
 
 class InspectorSessionDelegate {
  public:
+  virtual ~InspectorSessionDelegate() = default;
   virtual bool WaitForFrontendMessage() = 0;
   virtual void OnMessage(const v8_inspector::StringView& message) = 0;
 };