test: add test for invalid cert string

`tls.parseCertString()` should return an empty object if passed an invalid cert string. This behavior is not currently tested. Add minimal test. PR-URL: #8179 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Yorkie Liu <[email protected]>
nodejs · Aug 24, 2016 · b9b762f · b9b762f
1 parent a6f8379
commit b9b762f
Showing 1 changed file with 29 additions and 19 deletions.
diff --git a/test/parallel/test-tls-parse-cert-string.js b/test/parallel/test-tls-parse-cert-string.js
@@ -4,23 +4,33 @@ require('../common');
 const assert = require('assert');
 const tls = require('tls');
 
-const singles = 'C=US\nST=CA\nL=SF\nO=Node.js Foundation\nOU=Node.js\n' +
-                'CN=ca1\[email protected]';
-const singlesOut = tls.parseCertString(singles);
-assert.deepStrictEqual(singlesOut, {
-  C: 'US',
-  ST: 'CA',
-  L: 'SF',
-  O: 'Node.js Foundation',
-  OU: 'Node.js',
-  CN: 'ca1',
-  emailAddress: '[email protected]'
-});
+{
+  const singles = 'C=US\nST=CA\nL=SF\nO=Node.js Foundation\nOU=Node.js\n' +
+                  'CN=ca1\[email protected]';
+  const singlesOut = tls.parseCertString(singles);
+  assert.deepStrictEqual(singlesOut, {
+    C: 'US',
+    ST: 'CA',
+    L: 'SF',
+    O: 'Node.js Foundation',
+    OU: 'Node.js',
+    CN: 'ca1',
+    emailAddress: '[email protected]'
+  });
+}
 
-const doubles = 'OU=Domain Control Validated\nOU=PositiveSSL Wildcard\n' +
-                'CN=*.nodejs.org';
-const doublesOut = tls.parseCertString(doubles);
-assert.deepStrictEqual(doublesOut, {
-  OU: [ 'Domain Control Validated', 'PositiveSSL Wildcard' ],
-  CN: '*.nodejs.org'
-});
+{
+  const doubles = 'OU=Domain Control Validated\nOU=PositiveSSL Wildcard\n' +
+                  'CN=*.nodejs.org';
+  const doublesOut = tls.parseCertString(doubles);
+  assert.deepStrictEqual(doublesOut, {
+    OU: [ 'Domain Control Validated', 'PositiveSSL Wildcard' ],
+    CN: '*.nodejs.org'
+  });
+}
+
+{
+  const invalid = 'fhqwhgads';
+  const invalidOut = tls.parseCertString(invalid);
+  assert.deepStrictEqual(invalidOut, {});
+}