From b5a8376ffe2f380103ebe7f7314d5c7a12500084 Mon Sep 17 00:00:00 2001 From: Sam Roberts Date: Thu, 31 Jan 2019 13:51:20 -0800 Subject: [PATCH] src: organize TLSWrap declarations by parent Make it clear which of the multiple interfaces a TLSWrap method is implementing by grouping and commenting the related methods. PR-URL: https://github.com/nodejs/node/pull/25861 Reviewed-By: Fedor Indutny Reviewed-By: Anna Henningsen --- src/tls_wrap.h | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/tls_wrap.h b/src/tls_wrap.h index be96e76503af87..cc91c2edc7f111 100644 --- a/src/tls_wrap.h +++ b/src/tls_wrap.h @@ -57,16 +57,19 @@ class TLSWrap : public AsyncWrap, v8::Local context, void* priv); - int GetFD() override; + // Implement StreamBase: bool IsAlive() override; bool IsClosing() override; - - // JavaScript functions - int ReadStart() override; - int ReadStop() override; - + bool IsIPCPipe() override; + int GetFD() override; ShutdownWrap* CreateShutdownWrap( v8::Local req_wrap_object) override; + AsyncWrap* GetAsyncWrap() override; + + + // Implement StreamResource: + int ReadStart() override; // Exposed to JS + int ReadStop() override; // Exposed to JS int DoShutdown(ShutdownWrap* req_wrap) override; int DoWrite(WriteWrap* w, uv_buf_t* bufs, @@ -79,8 +82,8 @@ class TLSWrap : public AsyncWrap, void NewSessionDoneCb(); + // Implement MemoryRetainer: void MemoryInfo(MemoryTracker* tracker) const override; - SET_MEMORY_INFO_NAME(TLSWrap) SET_SELF_SIZE(TLSWrap) @@ -136,13 +139,11 @@ class TLSWrap : public AsyncWrap, } } - AsyncWrap* GetAsyncWrap() override; - bool IsIPCPipe() override; - - // Resource implementation - void OnStreamAfterWrite(WriteWrap* w, int status) override; + // Implement StreamListener: + // Returns buf that points into enc_in_. uv_buf_t OnStreamAlloc(size_t size) override; void OnStreamRead(ssize_t nread, const uv_buf_t& buf) override; + void OnStreamAfterWrite(WriteWrap* w, int status) override; v8::Local GetSSLError(int status, int* err, std::string* msg);