From b51db7120e1a1040ae2945c331bf09f8fb75150b Mon Sep 17 00:00:00 2001 From: "Sakthipriyan Vairamani (thefourtheye)" Date: Sun, 9 Oct 2016 19:54:23 +0530 Subject: [PATCH] build: make node-gyp output silent As it is, node-gyp produces a lot of build related verbose messages. Latest node-gyp upgrade allows us to specify --silent flag to suppress those messages. Except for CI, addons build will run silently. PR-URL: https://github.com/nodejs/node/pull/8990 Reviewed-By: Daniel Bevenius Reviewed-By: Gibson Fahnestock Reviewed-By: Ilkka Myller Reviewed-By: Fedor Indutny Reviewed-By: James M Snell Reviewed-By: Rod Vagg --- Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 33bcce6afddc22..3e30589a6aecf9 100644 --- a/Makefile +++ b/Makefile @@ -8,6 +8,7 @@ PREFIX ?= /usr/local FLAKY_TESTS ?= run TEST_CI_ARGS ?= STAGINGSERVER ?= node-www +LOGLEVEL ?= silent OSTYPE := $(shell uname -s | tr '[A-Z]' '[a-z]') ifdef JOBS @@ -165,7 +166,8 @@ test/addons/.buildstamp: config.gypi \ # Cannot use $(wildcard test/addons/*/) here, it's evaluated before # embedded addons have been generated from the documentation. for dirname in test/addons/*/; do \ - $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \ + echo "\nRunning addons test $$PWD/$$dirname" ; \ + $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp --loglevel=$(LOGLEVEL) rebuild \ --python="$(PYTHON)" \ --directory="$$PWD/$$dirname" \ --nodedir="$$PWD" || exit 1 ; \ @@ -195,6 +197,7 @@ CI_NATIVE_SUITES := addons CI_JS_SUITES := doctool inspector known_issues message parallel pseudo-tty sequential # Build and test addons without building anything else +test-ci-native: LOGLEVEL := info test-ci-native: | test/addons/.buildstamp $(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \ --mode=release --flaky-tests=$(FLAKY_TESTS) \ @@ -206,6 +209,7 @@ test-ci-js: --mode=release --flaky-tests=$(FLAKY_TESTS) \ $(TEST_CI_ARGS) $(CI_JS_SUITES) +test-ci: LOGLEVEL := info test-ci: | build-addons out/Release/cctest --gtest_output=tap:cctest.tap $(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \