test: improve coverage of lib/events.js

PR-URL: #38582 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
nodejs · Jul 20, 2021 · b3b5995 · b3b5995
1 parent cd48ee7
commit b3b5995
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/test/parallel/test-event-emitter-emit-context.js b/test/parallel/test-event-emitter-emit-context.js
@@ -0,0 +1,18 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const EventEmitter = require('events');
+
+// Test emit called by other context
+const EE = new EventEmitter();
+
+// Works as expected if the context has no `constructor.name`
+{
+  const ctx = Object.create(null);
+  assert.throws(
+    () => EE.emit.call(ctx, 'error', new Error('foo')),
+    common.expectsError({ name: 'Error', message: 'foo' })
+  );
+}
+
+assert.strictEqual(EE.emit.call({}, 'foo'), false);
diff --git a/.../parallel/test-event-on-async-iterator.js → ...parallel/test-events-on-async-iterator.js b/.../parallel/test-event-on-async-iterator.js → ...parallel/test-events-on-async-iterator.js
@@ -37,6 +37,13 @@ async function basic() {
   assert.strictEqual(ee.listenerCount('error'), 0);
 }
 
+async function invalidArgType() {
+  assert.throws(() => on({}, 'foo'), common.expectsError({
+    code: 'ERR_INVALID_ARG_TYPE',
+    name: 'TypeError',
+  }));
+}
+
 async function error() {
   const ee = new EventEmitter();
   const _err = new Error('kaboom');
@@ -363,6 +370,7 @@ async function abortableOnAfterDone() {
 async function run() {
   const funcs = [
     basic,
+    invalidArgType,
     error,
     errorDelayed,
     throwInLoop,