From b353549f7c5ea1dc3aea9a5bc81485e755e23ee9 Mon Sep 17 00:00:00 2001
From: Joyee Cheung <joyeec9h3@gmail.com>
Date: Wed, 27 Jan 2021 19:18:28 +0800
Subject: [PATCH] doc: mention adding Fixes to collaborator onboarding PR

Also update the example to include the Fixes url.

PR-URL: https://github.com/nodejs/node/pull/37097
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
---
 onboarding.md | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/onboarding.md b/onboarding.md
index 8036e459f5122a..ba75958db55317 100644
--- a/onboarding.md
+++ b/onboarding.md
@@ -204,11 +204,14 @@ needs to be pointed out separately during the onboarding.
 ## Exercise: Make a PR adding yourself to the README
 
 * Example:
-  <https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0>
-  * For raw commit message: `git log ce986de829457c39257cd205067602e765768fb0
-    -1`
+  <https://github.com/nodejs/node/commit/b58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8>
+  * For raw commit message:
+    `git show --format=%Bb58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8`
 * Collaborators are in alphabetical order by GitHub username.
 * Optionally, include your personal pronouns.
+* Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message
+  so that when the commit lands, the nomination issue url will be
+  automatically closed.
 * Label your pull request with the `doc`, `notable-change`, and `fast-track`
   labels.
 * Run CI on the PR. Use the `node-test-pull-request` CI task.