test: refactor domain tests

* Check that noop callback is or isn't invoked as appropriate using common.mustCall() and common.mustNotCall() * Fix typo in array literal PR-URL: #13480 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs · Jun 10, 2017 · ad07c46 · ad07c46
1 parent fe5ea3f
commit ad07c46
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/test/parallel/test-domain-crypto.js b/test/parallel/test-domain-crypto.js
@@ -37,9 +37,9 @@ global.domain = require('domain');
 
 // should not throw a 'TypeError: undefined is not a function' exception
 crypto.randomBytes(8);
-crypto.randomBytes(8, common.noop);
+crypto.randomBytes(8, common.mustCall());
 const buf = Buffer.alloc(8);
 crypto.randomFillSync(buf);
 crypto.pseudoRandomBytes(8);
-crypto.pseudoRandomBytes(8, common.noop);
-crypto.pbkdf2('password', 'salt', 8, 8, 'sha1', common.noop);
+crypto.pseudoRandomBytes(8, common.mustCall());
+crypto.pbkdf2('password', 'salt', 8, 8, 'sha1', common.mustCall());
diff --git a/test/parallel/test-domain-timers.js b/test/parallel/test-domain-timers.js
@@ -51,4 +51,4 @@ immediated.run(function() {
   });
 });
 
-const timeout = setTimeout(common.noop, 10 * 1000);
+const timeout = setTimeout(common.mustNotCall(), 10 * 1000);
diff --git a/test/parallel/test-domain.js b/test/parallel/test-domain.js
@@ -22,7 +22,7 @@
 'use strict';
 // Simple tests of most basic domain functionality.
 
-const common = require('../common');
+require('../common');
 const assert = require('assert');
 const domain = require('domain');
 const events = require('events');
@@ -259,7 +259,7 @@ const fst = fs.createReadStream('stream for nonexistent file');
 d.add(fst);
 expectCaught++;
 
-[42, null, , false, common.noop, 'string'].forEach(function(something) {
+[42, null, undefined, false, () => {}, 'string'].forEach(function(something) {
   const d = new domain.Domain();
   d.run(function() {
     process.nextTick(function() {
-Original file line number
+Diff line change
@@ Expand Up / @@ -51,4 +51,4 @@ immediated.run(function() { @@
       });
     });
-    const timeout = setTimeout(common.noop, 10 * 1000);
+    const timeout = setTimeout(common.mustNotCall(), 10 * 1000);