From ac70bc82404ec60a71e651a9e16dd4910c020b72 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Thu, 16 Jul 2015 11:17:22 +0200 Subject: [PATCH] test: fix valgrind uninitialized memory warning parallel/test-buffer called `Buffer.prototype.toString()` on a buffer with uninitialized memory. Call `Buffer.prototype.fill()` on it first. PR-URL: https://github.com/nodejs/io.js/pull/2193 Reviewed-By: Trevor Norris --- test/parallel/test-buffer.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/parallel/test-buffer.js b/test/parallel/test-buffer.js index 02d902b199e23d..27a211bc2da8fd 100644 --- a/test/parallel/test-buffer.js +++ b/test/parallel/test-buffer.js @@ -802,7 +802,9 @@ assert.equal(buf[4], 0); // Check for fractional length args, junk length args, etc. // https://github.com/joyent/node/issues/1758 -Buffer(3.3).toString(); // throws bad argument error in commit 43cb4ec + +// Call .fill() first, stops valgrind warning about uninitialized memory reads. +Buffer(3.3).fill().toString(); // throws bad argument error in commit 43cb4ec assert.equal(Buffer(-1).length, 0); assert.equal(Buffer(NaN).length, 0); assert.equal(Buffer(3.3).length, 3);