From ab5dbf9eb0e27534ab29116262c5b73bfbedd78d Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sun, 31 Mar 2019 14:22:58 -0400 Subject: [PATCH] build: only emit download ICU warnings once The check that the user specified `icu` in `--download` only needs to be done once and not for each entry in `tools/icu/current_ver.dep`. Fixes: https://github.com/nodejs/node/issues/26860 PR-URL: https://github.com/nodejs/node/pull/27031 Reviewed-By: Refael Ackermann Reviewed-By: Ruben Bridgewater Signed-off-by: Beth Griggs --- configure.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure.py b/configure.py index 8ae56fdeff2b7e..9f780ab9bca150 100755 --- a/configure.py +++ b/configure.py @@ -1311,13 +1311,14 @@ def icu_download(path): if not os.access(options.download_path, os.W_OK): error('''Cannot write to desired download path. Either create it or verify permissions.''') + attemptdownload = nodedownload.candownload(auto_downloads, "icu") for icu in icus: url = icu['url'] md5 = icu['md5'] local = url.split('/')[-1] targetfile = os.path.join(options.download_path, local) if not os.path.isfile(targetfile): - if nodedownload.candownload(auto_downloads, "icu"): + if attemptdownload: nodedownload.retrievefile(url, targetfile) else: print('Re-using existing %s' % targetfile)