Skip to content

Commit

Permalink
test: add read_only_space heap space
Browse files Browse the repository at this point in the history
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: nodejs/node-v8#44

PR-URL: #19989
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
  • Loading branch information
cjihrig authored and MylesBorins committed Jun 1, 2018
1 parent 2d3137c commit aa08f64
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/parallel/test-v8-stats.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ const expectedHeapSpaces = [
'old_space',
'code_space',
'map_space',
'large_object_space'
'large_object_space',
'read_only_space'
];
const heapSpaceStatistics = v8.getHeapSpaceStatistics();
const actualHeapSpaceNames = heapSpaceStatistics.map((s) => s.space_name);
Expand Down

0 comments on commit aa08f64

Please sign in to comment.