async_hooks: prevent sync methods of async storage exiting outer context

PR-URL: #31950 Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
nodejs · Apr 14, 2020 · a683e87 · a683e87
1 parent 4e5ec41
commit a683e87
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 12 deletions.
diff --git a/lib/async_hooks.js b/lib/async_hooks.js
@@ -257,14 +257,11 @@ class AsyncLocalStorage {
   }
 
   runSyncAndReturn(store, callback, ...args) {
-    const resource = executionAsyncResource();
-    const outerStore = resource[this.kResourceStore];
-    this.enterWith(store);
-    try {
+    const resource = new AsyncResource('AsyncLocalStorage');
+    return resource.runInAsyncScope(() => {
+      this.enterWith(store);
       return callback(...args);
-    } finally {
-      resource[this.kResourceStore] = outerStore;
-    }
+    });
   }
 
   exitSyncAndReturn(callback, ...args) {
@@ -287,11 +284,10 @@ class AsyncLocalStorage {
   }
 
   run(store, callback, ...args) {
-    const resource = executionAsyncResource();
-    const outerStore = resource[this.kResourceStore];
-    this.enterWith(store);
-    process.nextTick(callback, ...args);
-    resource[this.kResourceStore] = outerStore;
+    process.nextTick(() => {
+      this.enterWith(store);
+      return callback(...args);
+    });
   }
 
   exit(callback, ...args) {

diff --git a/test/async-hooks/test-async-local-storage-run-resource.js b/test/async-hooks/test-async-local-storage-run-resource.js
@@ -0,0 +1,17 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+const {
+  AsyncLocalStorage,
+  executionAsyncResource
+} = require('async_hooks');
+
+const asyncLocalStorage = new AsyncLocalStorage();
+
+const outerResource = executionAsyncResource();
+
+asyncLocalStorage.run(new Map(), () => {
+  assert.notStrictEqual(executionAsyncResource(), outerResource);
+});
+
+assert.strictEqual(executionAsyncResource(), outerResource);