test: enhance test-common.js

* refactor test-common.js so that global leak detection does not need to be disabled * add test for common.fail() PR-URL: #11433 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
nodejs · Feb 22, 2017 · a523482 · a523482
1 parent 3d133eb
commit a523482
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/test/parallel/test-common.js b/test/parallel/test-common.js
@@ -2,14 +2,25 @@
 const common = require('../common');
 const assert = require('assert');
 
-common.globalCheck = false;
+
+// test for leaked global detection
 global.gc = 42;  // Not a valid global unless --expose_gc is set.
 assert.deepStrictEqual(common.leakedGlobals(), ['gc']);
+delete global.gc;
+
 
+// common.mustCall() tests
 assert.throws(function() {
   common.mustCall(function() {}, 'foo');
 }, /^TypeError: Invalid expected value: foo$/);
 
 assert.throws(function() {
   common.mustCall(function() {}, /foo/);
 }, /^TypeError: Invalid expected value: \/foo\/$/);
+
+
+// common.fail() tests
+assert.throws(
+  () => { common.fail('fhqwhgads'); },
+  /^AssertionError: fhqwhgads$/
+);