Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adds missing return which fixes debug builds on Windows Fixes: #13392 Ref: https://codereview.chromium.org/2929993003/ PR-URL: #13634 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
- Loading branch information
a0f8faa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch did not bump the V8 patch number. We have also generally been using the "deps" subsystem for V8.
a0f8faa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also... is this something backported from upstream? If not did we send a patch?
Since it appears to be backported it likely should have had the original CL meta data. Looking at the upstream issue it appears to have been reverted, is this something we need to worry about?
Sorry about being so pedantic here, just auditing some V8 stuff during the release and these commits seemed odd
a0f8faa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but the PR was opened before the upstream patch was merged, so it was reviewed independently as well.
No. :) The patch was reverted because V8 tweaked its compiler flags later so that it became unnecessary.
a0f8faa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and: This doesn’t need to be backported.