Skip to content

Commit

Permalink
doc: updated guidance for n-api changes
Browse files Browse the repository at this point in the history
Add js_native_api.h and js_native_api_types.h to the list
of files covered by the N-API guidance as these were
broken out of the files referenced.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #32721
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
  • Loading branch information
mhdawson authored and BridgeAR committed Apr 28, 2020
1 parent 5c4d8cd commit a0be60e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions doc/guides/collaborator-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,8 @@ For pull requests introducing new core modules:
### Additions to N-API

N-API provides an ABI-stable API guaranteed for future Node.js versions. N-API
additions call for unusual care and scrutiny. If a change adds to `node_api.h`
or `node_api_types.h`, consult [the relevant
additions call for unusual care and scrutiny. If a change adds to `node_api.h`,
`js_native_api.h`, `node_api_types.h`, or `js_native_api_types.h`, consult [the relevant
guide](https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md).

### Deprecations
Expand Down

0 comments on commit a0be60e

Please sign in to comment.