test: skip failing tests for osx mojave

Refs: #21679 PR-URL: #23550 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
nodejs · Oct 30, 2018 · 9f15bc4 · 9f15bc4
1 parent aba1ff2
commit 9f15bc4
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 1 deletion.
diff --git a/test/common/index.js b/test/common/index.js
@@ -47,7 +47,8 @@ exports.isSunOS = process.platform === 'sunos';
 exports.isFreeBSD = process.platform === 'freebsd';
 exports.isOpenBSD = process.platform === 'openbsd';
 exports.isLinux = process.platform === 'linux';
-exports.isOSX = process.platform === 'darwin';
+const isOSX = exports.isOSX = process.platform === 'darwin';
+exports.isOSXMojave = isOSX && (os.release().startsWith('18'));
 
 exports.enoughTestMem = os.totalmem() > 0x70000000; /* 1.75 Gb */
 const cpus = os.cpus();

diff --git a/test/known_issues/test-cluster-bind-privileged-port.js b/test/known_issues/test-cluster-bind-privileged-port.js
@@ -0,0 +1,25 @@
+'use strict';
+const common = require('../common');
+
+// This test should fail on macOS (10.14) due to an issue with privileged ports.
+
+const assert = require('assert');
+const cluster = require('cluster');
+const net = require('net');
+
+if (!common.isOSXMojave)
+  assert.fail('Code should fail only on macOS Mojave.');
+
+
+if (cluster.isMaster) {
+  cluster.fork().on('exit', common.mustCall((exitCode) => {
+    assert.strictEqual(exitCode, 0);
+  }));
+} else {
+  const s = net.createServer(common.mustNotCall());
+  s.listen(42, common.mustNotCall('listen should have failed'));
+  s.on('error', common.mustCall((err) => {
+    assert.strictEqual(err.code, 'EACCES');
+    process.disconnect();
+  }));
+}
diff --git a/test/parallel/test-cluster-bind-privileged-port.js b/test/parallel/test-cluster-bind-privileged-port.js
@@ -21,6 +21,11 @@
 
 'use strict';
 const common = require('../common');
+
+// Skip on OS X Mojave. https://github.com/nodejs/node/issues/21679
+if (common.isOSXMojave)
+  common.skip('bypass test for Mojave due to OSX issue');
+
 if (common.isWindows)
   common.skip('not reliable on Windows.');
 

diff --git a/test/parallel/test-cluster-shared-handle-bind-privileged-port.js b/test/parallel/test-cluster-shared-handle-bind-privileged-port.js
@@ -21,6 +21,11 @@
 
 'use strict';
 const common = require('../common');
+
+// Skip on OS X Mojave. https://github.com/nodejs/node/issues/21679
+if (common.isOSXMojave)
+  common.skip('bypass test for Mojave due to OSX issue');
+
 if (common.isWindows)
   common.skip('not reliable on Windows');