From 9d7574eef54de1a3675eb58328aeac17d6327de4 Mon Sep 17 00:00:00 2001 From: Jackson Tian Date: Wed, 28 Jun 2017 01:20:12 +0800 Subject: [PATCH] module: deprecate Module._debug MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The _debug of Module is undocumented and it useless here. PR-URL: https://github.com/nodejs/node/pull/13948 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Michaƫl Zasso Reviewed-By: Timothy Gu Reviewed-By: Ruben Bridgewater --- doc/api/deprecations.md | 9 +++++++++ lib/module.js | 6 +++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 82391a32e84031..922d843d51cc5a 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -684,6 +684,15 @@ difference is that `querystring.parse()` does url encoding: { '%E5%A5%BD': '1' } ``` + +### DEP0077: Module.\_debug() + +Type: Runtime + +`Module._debug()` has been deprecated. + +*Note*: `Module._debug()` was never documented as an officially supported API. + [`Buffer.allocUnsafeSlow(size)`]: buffer.html#buffer_class_method_buffer_allocunsafeslow_size [`Buffer.from(array)`]: buffer.html#buffer_class_method_buffer_from_array [`Buffer.from(buffer)`]: buffer.html#buffer_class_method_buffer_from_buffer diff --git a/lib/module.js b/lib/module.js index 96f36c815a5c7e..7f25b63ddb8bf6 100644 --- a/lib/module.js +++ b/lib/module.js @@ -80,11 +80,11 @@ Module.globalPaths = []; Module.wrapper = NativeModule.wrapper; Module.wrap = NativeModule.wrap; -Module._debug = util.debuglog('module'); -// We use this alias for the preprocessor that filters it out -const debug = Module._debug; +const debug = util.debuglog('module'); +Module._debug = util.deprecate(debug, 'Module._debug is deprecated.', + 'DEP0077'); // given a module name, and a list of paths to test, returns the first // matching file in the following precedence.