quic: do not dereference shared_ptr after move

The stored pointer is assumed to be nullptr after std::move. PR-URL: #47294 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
nodejs · Mar 29, 2023 · 9b104be · 9b104be
1 parent c81e114
commit 9b104be
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/quic/data.cc b/src/quic/data.cc
@@ -38,16 +38,16 @@ Store::Store(std::shared_ptr<v8::BackingStore> store,
              size_t length,
              size_t offset)
     : store_(std::move(store)), length_(length), offset_(offset) {
-  CHECK_LE(offset_, store->ByteLength());
-  CHECK_LE(length_, store->ByteLength() - offset_);
+  CHECK_LE(offset_, store_->ByteLength());
+  CHECK_LE(length_, store_->ByteLength() - offset_);
 }
 
 Store::Store(std::unique_ptr<v8::BackingStore> store,
              size_t length,
              size_t offset)
     : store_(std::move(store)), length_(length), offset_(offset) {
-  CHECK_LE(offset_, store->ByteLength());
-  CHECK_LE(length_, store->ByteLength() - offset_);
+  CHECK_LE(offset_, store_->ByteLength());
+  CHECK_LE(length_, store_->ByteLength() - offset_);
 }
 
 Store::Store(v8::Local<v8::ArrayBuffer> buffer, Option option)