util: avoid using forEach

PR-URL: #11582 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs · Mar 20, 2017 · 9a59913 · 9a59913
1 parent 5b1d61c
commit 9a59913
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/lib/util.js b/lib/util.js
@@ -682,12 +682,13 @@ function formatArray(ctx, value, recurseTimes, visibleKeys, keys) {
   if (remaining > 0) {
     output.push(`... ${remaining} more item${remaining > 1 ? 's' : ''}`);
   }
-  keys.forEach(function(key) {
+  for (var n = 0; n < keys.length; n++) {
+    var key = keys[n];
     if (typeof key === 'symbol' || !key.match(/^\d+$/)) {
       output.push(formatProperty(ctx, value, recurseTimes, visibleKeys,
                                  key, true));
     }
-  });
+  }
   return output;
 }
 
@@ -718,10 +719,10 @@ function formatSet(ctx, value, recurseTimes, visibleKeys, keys) {
     var str = formatValue(ctx, v, nextRecurseTimes);
     output.push(str);
   });
-  keys.forEach(function(key) {
+  for (var n = 0; n < keys.length; n++) {
     output.push(formatProperty(ctx, value, recurseTimes, visibleKeys,
-                               key, false));
-  });
+                               keys[n], false));
+  }
   return output;
 }
 
@@ -735,10 +736,10 @@ function formatMap(ctx, value, recurseTimes, visibleKeys, keys) {
     str += formatValue(ctx, v, nextRecurseTimes);
     output.push(str);
   });
-  keys.forEach(function(key) {
+  for (var n = 0; n < keys.length; n++) {
     output.push(formatProperty(ctx, value, recurseTimes, visibleKeys,
-                               key, false));
-  });
+                               keys[n], false));
+  }
   return output;
 }
 
@@ -768,10 +769,10 @@ function formatPromise(ctx, value, recurseTimes, visibleKeys, keys) {
       output.push(str);
     }
   }
-  keys.forEach(function(key) {
+  for (var n = 0; n < keys.length; n++) {
     output.push(formatProperty(ctx, value, recurseTimes, visibleKeys,
-                               key, false));
-  });
+                               keys[n], false));
+  }
   return output;
 }