test: update web-platform tests for url

PR-URL: #46547 Backport-PR-URL: #47435 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Apr 12, 2023 · 972bdee · 972bdee
1 parent 484c4f6
commit 972bdee
Show file tree

Hide file tree

Showing 17 changed files with 10,305 additions and 8 deletions.
diff --git a/test/fixtures/wpt/README.md b/test/fixtures/wpt/README.md
@@ -27,7 +27,7 @@ Last update:
 - performance-timeline: https://github.com/web-platform-tests/wpt/tree/17ebc3aea0/performance-timeline
 - resources: https://github.com/web-platform-tests/wpt/tree/fbf1e7d247/resources
 - streams: https://github.com/web-platform-tests/wpt/tree/9e5ef42bd3/streams
-- url: https://github.com/web-platform-tests/wpt/tree/0a187bc169/url
+- url: https://github.com/web-platform-tests/wpt/tree/f1ade799d0/url
 - user-timing: https://github.com/web-platform-tests/wpt/tree/df24fb604e/user-timing
 - wasm/jsapi: https://github.com/web-platform-tests/wpt/tree/d8dbe6990b/wasm/jsapi
 - wasm/webapi: https://github.com/web-platform-tests/wpt/tree/fd1b23eeaa/wasm/webapi

diff --git a/test/fixtures/wpt/url/IdnaTestV2.window.js b/test/fixtures/wpt/url/IdnaTestV2.window.js
@@ -0,0 +1,41 @@
+promise_test(() => fetch("resources/IdnaTestV2.json").then(res => res.json()).then(runTests), "Loading data…");
+
+// Performance impact of this seems negligible (performance.now() diff in WebKit went from 48 to 52)
+// and there was a preference to let more non-ASCII hit the parser.
+function encodeHostEndingCodePoints(input) {
+  let output = "";
+  for (const codePoint of input) {
+    if ([":", "/", "?", "#", "\\"].includes(codePoint)) {
+      output += encodeURIComponent(codePoint);
+    } else {
+      output += codePoint;
+    }
+  }
+  return output;
+}
+
+function runTests(idnaTests) {
+  for (const idnaTest of idnaTests) {
+    if (typeof idnaTest === "string") {
+      continue // skip comments
+    }
+    if (idnaTest.input === "") {
+      continue // cannot test empty string input through new URL()
+    }
+    // Percent-encode the input such that ? and equivalent code points do not end up counting as
+    // part of the URL, but are parsed through the host parser instead.
+    const encodedInput = encodeHostEndingCodePoints(idnaTest.input);
+
+    test(() => {
+      if (idnaTest.output === null) {
+        assert_throws_js(TypeError, () => new URL(`https://${encodedInput}/x`));
+      } else {
+        const url = new URL(`https://${encodedInput}/x`);
+        assert_equals(url.host, idnaTest.output);
+        assert_equals(url.hostname, idnaTest.output);
+        assert_equals(url.pathname, "/x");
+        assert_equals(url.href, `https://${idnaTest.output}/x`);
+      }
+    }, `ToASCII("${idnaTest.input}")${idnaTest.comment ? " " + idnaTest.comment : ""}`);
+  }
+}
diff --git a/test/fixtures/wpt/url/a-element-xhtml.xhtml b/test/fixtures/wpt/url/a-element-xhtml.xhtml
@@ -3,8 +3,13 @@
 <html xmlns="http://www.w3.org/1999/xhtml">
   <head>
     <title>URL Test</title>
+    <meta name="variant" content="?include=file"/>
+    <meta name="variant" content="?include=javascript"/>
+    <meta name="variant" content="?include=mailto"/>
+    <meta name="variant" content="?exclude=(file|javascript|mailto)"/>
     <script src="/resources/testharness.js"></script>
     <script src="/resources/testharnessreport.js"></script>
+    <script src="/common/subset-tests-by-key.js"></script>
     <base id="base"/>
   </head>
   <body>

diff --git a/test/fixtures/wpt/url/a-element.html b/test/fixtures/wpt/url/a-element.html
@@ -1,7 +1,12 @@
 <!doctype html>
 <meta charset=utf-8>
+<meta name="variant" content="?include=file">
+<meta name="variant" content="?include=javascript">
+<meta name="variant" content="?include=mailto">
+<meta name="variant" content="?exclude=(file|javascript|mailto)">
 <script src=/resources/testharness.js></script>
 <script src=/resources/testharnessreport.js></script>
+<script src="/common/subset-tests-by-key.js"></script>
 <base id=base>
 <div id=log></div>
 <script src=resources/a-element.js></script>

diff --git a/test/fixtures/wpt/url/historical.any.js b/test/fixtures/wpt/url/historical.any.js
@@ -28,4 +28,12 @@ test(function() {
   assert_equals(URL.domainToUnicode, undefined);
 }, "URL.domainToUnicode should be undefined");
 
+test(() => {
+  assert_throws_dom("DataCloneError", () => self.structuredClone(new URL("about:blank")));
+}, "URL: no structured serialize/deserialize support");
+
+test(() => {
+  assert_throws_dom("DataCloneError", () => self.structuredClone(new URLSearchParams()));
+}, "URLSearchParams: no structured serialize/deserialize support");
+
 done();