Skip to content

Commit

Permalink
benchmark: rename count to n
Browse files Browse the repository at this point in the history
It's a common approach to use n as number of iterations over the
benchmark. Changing it from count to n will also make
./node benchmark/run.js --set n=X more meaningful among other
benchmarks

PR-URL: #54271
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
  • Loading branch information
RafaelGSS authored and targos committed Oct 2, 2024
1 parent 6a4f05e commit 93ee36e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
12 changes: 6 additions & 6 deletions benchmark/misc/startup-cli-version.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ const availableCli = [
].filter((cli) => existsSync(path.resolve(__dirname, '../../', cli)));
const bench = common.createBenchmark(main, {
cli: availableCli,
count: [30],
n: [30],
});

function spawnProcess(cli, bench, state) {
const cmd = process.execPath || process.argv[0];
while (state.finished < state.count) {
while (state.finished < state.n) {
const child = spawnSync(cmd, [cli, '--version'], {
env: { npm_config_loglevel: 'silent', ...process.env },
});
Expand All @@ -41,15 +41,15 @@ function spawnProcess(cli, bench, state) {
bench.start();
}

if (state.finished === state.count) {
bench.end(state.count);
if (state.finished === state.n) {
bench.end(state.n);
}
}
}

function main({ count, cli }) {
function main({ n, cli }) {
cli = path.resolve(__dirname, '../../', cli);
const warmup = 3;
const state = { count, finished: -warmup };
const state = { n, finished: -warmup };
spawnProcess(cli, bench, state);
}
16 changes: 8 additions & 8 deletions benchmark/misc/startup-core.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ const bench = common.createBenchmark(main, {
'test/fixtures/semicolon',
],
mode: ['process', 'worker'],
count: [30],
n: [30],
});

function spawnProcess(script, bench, state) {
const cmd = process.execPath || process.argv[0];
while (state.finished < state.count) {
while (state.finished < state.n) {
const child = spawnSync(cmd, [script]);
if (child.status !== 0) {
console.log('---- STDOUT ----');
Expand All @@ -31,8 +31,8 @@ function spawnProcess(script, bench, state) {
bench.start();
}

if (state.finished === state.count) {
bench.end(state.count);
if (state.finished === state.n) {
bench.end(state.n);
}
}
}
Expand All @@ -48,18 +48,18 @@ function spawnWorker(script, bench, state) {
// Finished warmup.
bench.start();
}
if (state.finished < state.count) {
if (state.finished < state.n) {
spawnWorker(script, bench, state);
} else {
bench.end(state.count);
bench.end(state.n);
}
});
}

function main({ count, script, mode }) {
function main({ n, script, mode }) {
script = path.resolve(__dirname, '../../', `${script}.js`);
const warmup = 3;
const state = { count, finished: -warmup };
const state = { n, finished: -warmup };
if (mode === 'worker') {
Worker = require('worker_threads').Worker;
spawnWorker(script, bench, state);
Expand Down

0 comments on commit 93ee36e

Please sign in to comment.