assert: improve error check

Minor performance improvement. PR-URL: #17574 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Mar 20, 2018 · 8d33e5c · 8d33e5c
1 parent 9c0c0e6
commit 8d33e5c
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -219,10 +219,14 @@ class AssertionError extends Error {
         red = '\u001b[31m';
       }
       const util = lazyUtil();
-      if (actual && actual.stack && actual instanceof Error)
+      if (typeof actual === 'object' && actual !== null &&
+        'stack' in actual && actual instanceof Error) {
         actual = `${actual.name}: ${actual.message}`;
-      if (expected && expected.stack && expected instanceof Error)
+      }
+      if (typeof expected === 'object' && expected !== null &&
+        'stack' in expected && expected instanceof Error) {
         expected = `${expected.name}: ${expected.message}`;
+      }
 
       if (errorDiff === 0) {
         let res = util.inspect(actual);