src: add a condition if the argument of DomainToUnicode is empty

PR-URL: #49097 Refs: #46410 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
nodejs · Nov 26, 2023 · 8c33731 · 8c33731
1 parent 9e1c531
commit 8c33731
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -95,6 +95,11 @@ void BindingData::DomainToUnicode(const FunctionCallbackInfo<Value>& args) {
   CHECK(args[0]->IsString());
 
   std::string input = Utf8Value(env->isolate(), args[0]).ToString();
+  if (input.empty()) {
+    return args.GetReturnValue().Set(
+        String::NewFromUtf8(env->isolate(), "").ToLocalChecked());
+  }
+
   // It is important to have an initial value that contains a special scheme.
   // Since it will change the implementation of `set_hostname` according to URL
   // spec.