From 8b85d471124ee1702bcf5692756a782e08e26d2c Mon Sep 17 00:00:00 2001 From: Myles Borins Date: Mon, 24 Oct 2016 12:03:53 -0400 Subject: [PATCH] tools: use long format for gpg fingerprint MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Git has been using my Long format fingerprint in the tagging messages, this has been causing the release script to fail on my keys. It would also be wise to be using the long format on keys based on some attacks that hack been found in the wild around short keys. PR-URL: https://github.com/nodejs/node/pull/9258 Reviewed-By: Johan Bergström Reviewed-By: James M Snell Reviewed-By: Rod Vagg --- tools/release.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/release.sh b/tools/release.sh index 23b05b4fe8e1ef..9a3b881bd54e7d 100755 --- a/tools/release.sh +++ b/tools/release.sh @@ -50,7 +50,7 @@ elif [ $keycount -ne 1 ]; then done fi -gpgfing=$(gpg --fingerprint $gpgkey | grep 'Key fingerprint =' | awk -F' = ' '{print $2}' | tr -d ' ') +gpgfing=$(gpg --keyid-format 0xLONG --fingerprint $gpgkey | grep 'Key fingerprint =' | awk -F' = ' '{print $2}' | tr -d ' ') if ! test "$(grep $gpgfing README.md)"; then echo 'Error: this GPG key fingerprint is not listed in ./README.md'