From 852a1a6742cc7a941276a4def7960b3a9b9b098b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=BCseyin=20A=C3=A7acak?= <110401522+huseyinacacak-janea@users.noreply.github.com> Date: Thu, 25 Jul 2024 13:08:16 +0300 Subject: [PATCH] build: avoid compiling with VS v17.10 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Refs: https://github.com/nodejs/build/issues/3739 PR-URL: https://github.com/nodejs/node/pull/53863 Reviewed-By: Michaël Zasso Reviewed-By: Yagiz Nizipli Reviewed-By: Gerhard Stöbich --- vcbuild.bat | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/vcbuild.bat b/vcbuild.bat index 95663cc9f59420..a2bed46dda65f0 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -283,6 +283,14 @@ goto exit :msbuild-found +@rem Visual Studio v17.10 has a bug that causes the build to fail. +@rem Check if the version is v17.10 and exit if it is. +echo %VSCMD_VER% | findstr /b /c:"17.10" >nul +if %errorlevel% neq 1 ( + echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version. + goto exit +) + @rem check if the clang-cl build is requested if not defined clang_cl goto clang-skip @rem x64 is hard coded as it is used for both cross and native compilation.