Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: make test-uv-binding-constant JS engine neutral
The error message validation in test-uv-binding-constant depends on the JS engine. The text will be different in node-chakracore than in V8-based versions of Node.js. Remove the message validation. Test that it is a TypeError only. We should only validate error messages when we control the contents of that error message (and not even necessarily then, but that is a minimum requirement). V8 and other underlying engines can change the error message at any time and that should not require us to change our tests (as changing tests suggests a semver-major change). PR-URL: #24666 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
- Loading branch information