Skip to content

Commit

Permalink
doc: document timed out Travis CI builds
Browse files Browse the repository at this point in the history
PR-URL: #30469
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
  • Loading branch information
richardlau authored and targos committed Dec 1, 2019
1 parent e8b06e4 commit 833cb00
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,13 @@ All pull requests must pass continuous integration tests. Code changes must pass
on [project CI server](https://ci.nodejs.org/). Pull requests that only change
documentation and comments can use Travis CI results.

Travis CI jobs have a fixed running time limit that building Node.js sometimes
exceeds. If the `Compile Node.js` Travis CI job has timed out it will fail after
around 45 minutes. The exit code will be 143, indicating that a `SIGTERM` signal
terminated the `make` command. When this happens, restart the timed out job. It
will reuse built artifacts from the previous timed-out run, and thus take less
time to complete.

Do not land any pull requests without passing (green or yellow) CI runs. If
there are CI failures unrelated to the change in the pull request, try "Resume
Build". It is in the left navigation of the relevant `node-test-pull-request`
Expand Down

0 comments on commit 833cb00

Please sign in to comment.