test: add an indicator isIBMi

We have to skip some test cases on IBM i. On IBM i, process.platform and os.platform() both return aix, It is not enough to differentiate between IBM i and real AIX system. Also updated parallel/test-cluster-bind-privileged-port.js for test. PR-URL: #30714 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs · Dec 3, 2019 · 81d81a5 · 81d81a5
1 parent 0aae502
commit 81d81a5
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 0 deletions.
diff --git a/test/common/README.md b/test/common/README.md
@@ -237,6 +237,11 @@ Attempts to 'kill' `pid`
 
 Platform check for Free BSD.
 
+### isIBMi
+* [&lt;boolean>][]
+
+Platform check for IBMi.
+
 ### isLinux
 * [&lt;boolean>][]
 

diff --git a/test/common/index.js b/test/common/index.js
@@ -102,6 +102,9 @@ if (process.argv.length === 2 &&
 
 const isWindows = process.platform === 'win32';
 const isAIX = process.platform === 'aix';
+// On IBMi, process.platform and os.platform() both return 'aix',
+// It is not enough to differentiate between IBMi and real AIX system.
+const isIBMi = os.type() === 'OS400';
 const isLinuxPPCBE = (process.platform === 'linux') &&
                      (process.arch === 'ppc64') &&
                      (os.endianness() === 'BE');
@@ -762,6 +765,7 @@ module.exports = {
   isAIX,
   isAlive,
   isFreeBSD,
+  isIBMi,
   isLinux,
   isLinuxPPCBE,
   isMainThread,

diff --git a/test/common/index.mjs b/test/common/index.mjs
@@ -9,6 +9,7 @@ const {
   isMainThread,
   isWindows,
   isAIX,
+  isIBMi,
   isLinuxPPCBE,
   isSunOS,
   isFreeBSD,
@@ -55,6 +56,7 @@ export {
   isMainThread,
   isWindows,
   isAIX,
+  isIBMi,
   isLinuxPPCBE,
   isSunOS,
   isFreeBSD,

diff --git a/test/parallel/test-cluster-bind-privileged-port.js b/test/parallel/test-cluster-bind-privileged-port.js
@@ -26,6 +26,9 @@ const common = require('../common');
 if (common.isOSX)
   common.skip('macOS may allow ordinary processes to use any port');
 
+if (common.isIBMi)
+  common.skip('IBMi may allow ordinary processes to use any port');
+
 if (common.isWindows)
   common.skip('not reliable on Windows.');