From 80b1717c0fa1b7c887bc614b610939153f50cbd8 Mon Sep 17 00:00:00 2001 From: Rongjian Zhang Date: Fri, 15 Nov 2019 22:54:32 +0800 Subject: [PATCH] tools: fix build at non-English windows PR-URL: https://github.com/nodejs/node/pull/30492 Fixes: https://github.com/nodejs/node/issues/25885 Reviewed-By: Anna Henningsen Reviewed-By: Daniel Bevenius --- tools/v8_gypfiles/v8.gyp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp index 0ecfc7e94518ef..b64df82fa38253 100644 --- a/tools/v8_gypfiles/v8.gyp +++ b/tools/v8_gypfiles/v8.gyp @@ -104,6 +104,13 @@ ], }, 'includes': ['toolchain.gypi', 'features.gypi'], + 'target_defaults': { + 'msvs_settings': { + 'VCCLCompilerTool': { + 'AdditionalOptions': ['/utf-8'] + } + }, + }, 'targets': [ { 'target_name': 'run_torque',