From 80a3766ac78616621150236693c266d84bc1382d Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 4 Jan 2022 19:50:14 -0800 Subject: [PATCH] build: use list for mutable retval rather than tuple MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We define `retval` as a tuple and then replace the tuple by "appending" items with `+=` but that actually creates a new tuple every time. Because it is intended to be mutable, use a list instead, then return a tuple from the function, as it should be immutable outside the function. PR-URL: https://github.com/nodejs/node/pull/41372 Reviewed-By: Christian Clauss Reviewed-By: Tobias Nießen --- configure.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.py b/configure.py index 0156afdc4c9163..a1b5c5570b6cb7 100755 --- a/configure.py +++ b/configure.py @@ -828,7 +828,7 @@ def pkg_config(pkg): otherwise (None, None, None, None)""" pkg_config = os.environ.get('PKG_CONFIG', 'pkg-config') args = [] # Print pkg-config warnings on first round. - retval = () + retval = [] for flag in ['--libs-only-l', '--cflags-only-I', '--libs-only-L', '--modversion']: args += [flag] @@ -843,9 +843,9 @@ def pkg_config(pkg): except OSError as e: if e.errno != errno.ENOENT: raise e # Unexpected error. return (None, None, None, None) # No pkg-config/pkgconf installed. - retval += (val,) + retval.append(val) args = ['--silence-errors'] - return retval + return tuple(retval) def try_check_compiler(cc, lang):